Theme token cleanups #4732
Theme token cleanups #4732
Conversation
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -802,6 +802,18 @@ | |||
| } | |||
| } | |||
| }, | |||
| "450": { | |||
There was a problem hiding this comment.
FYI -- Adding this color now to match Joelle's theme update designs. We have a lot of similar greens, so it would be worth revisiting and seeing if any can be pruned/consolidated.
|
|
||
| const CustomOption = styled(Box)` |
There was a problem hiding this comment.
FYI -- here is my proposal for how grommet teams can achieve the "bookend" easily. I'm thinking we should either::
- Have a recipe on our site for it
- Export it with grommet-theme-hpe
| @@ -742,6 +758,9 @@ const buildTheme = (tokens, flags) => { | |||
| radius: components.hpe.formField.medium.input.container.borderRadius, | |||
| color: components.hpe.formField.input.container.rest.borderColor, | |||
| }, | |||
| disabled: { | |||
| opacity: 1, | |||
There was a problem hiding this comment.
This is so that the disabled colors can drive the styling.
| @@ -2649,9 +2682,6 @@ const buildTheme = (tokens, flags) => { | |||
| }, | |||
| }, | |||
| }, | |||
| buttonGroup: { | |||
There was a problem hiding this comment.
This is not part of Grommet theme object, is just something we have locally in aries theme. Removing so it doesn't end up in grommet-theme-hpe.
|
✅ Deploy Preview for rad-shortbread-897892 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploy Preview
What does this PR do?
This modifies up theme.jsx to cleanup some lingering comments and fix how some component styles are being built up to better capture the necessary states (particularly touched checkbox, radiogroup, select).
Additionall this PR:
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?