No default withCredentials. Updated version of browserify#47

gsf · Jun 23, 2014 · 31e9c86 · 31e9c86
1 parent 7dc5009
commit 31e9c86
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/lib/request.js b/lib/request.js
@@ -15,11 +15,7 @@ var Request = module.exports = function (xhr, params) {
         + (params.path || '/')
     ;
 
-    if (typeof params.withCredentials === 'undefined') {
-        params.withCredentials = true;
-    }
-
-    try { xhr.withCredentials = params.withCredentials }
+    if (params.withCredentials) try { xhr.withCredentials = params.withCredentials }
     catch (e) {}
 
     if (params.responseType) try { xhr.responseType = params.responseType }

diff --git a/test/request_url.js b/test/request_url.js
@@ -67,8 +67,5 @@ test('Test withCredentials param', function(t) {
   var request = http.request({ url: url, withCredentials: true }, noop);
   t.equal( request.xhr.withCredentials, true, 'xhr.withCredentials should be true');
 
-  var request = http.request({ url: url }, noop);
-  t.equal( request.xhr.withCredentials, true, 'xhr.withCredentials should be true');
-
   t.end();
 });