Fix cdk-base on AWS deep learning AMI #1612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philmcmahon
force-pushed
the
pm-cdk-base-dlami
branch
4 times, most recently
from
535b4d2 to
86b297a
Compare
philmcmahon
force-pushed
the
pm-cdk-base-dlami
branch
from
86b297a to
bd18d64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The most significant change in this PR is that it removes the
| quotefilter (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/quote_filter.html) on the amigo data bucket variable in the cdk-base logs role. I found that this wasn't working when combined with the deep learning amigo base recipe. I did try to get this working - I think it's related to a different version of jinja2 being installed on the deep learning base recipe - but I couldn't get to the bottom of it, and this change does seem to workI'm not sure why we are quoting the bucket name and didn't find anything in Nic's pr where it was introduced (#706). I've tested on CODE to verify that this doesn't break anything.
I've also introduced a new aws_polling variable to the packer config, which is only set for bakes with an xlarge build instance, to stop these larger bakes from timing out (the dep learning AMI has 80GB or so of libraries on it so takes a long time to 'freeze' to an AMI)
This also adds a role to remove unattended-upgrades from the deep learning AMI as this causes problems
How to test