Upgrade @guardian/types to use Theme

[webb04]

Why are you doing this?

• Updates @guardian/types to 0.5.2
• Rename pillar helper functions to theme
• Removed featureHeadline and soft colours that aren't being used
• This should let us start work on special reports

[github-actions]

Before	After

[frankie297]

Do we have somewhere where we can add a definition of what is the difference between Theme and Pillar?

[webb04]

Do we have somewhere where we can add a definition of what is the difference between Theme and Pillar?

Not sure if we have any documentation around this @JamieB-gu ?

The types repo defines it here:
https://github.com/guardian/types/blob/main/Format.ts#L3-L15

We have the problem where the special report colours need to override pillar colours on special report articles.

It might be confusing to call them a pillar as we don't treat them as pillars in some places like CAPI and the navigation bar on dotcom for example. So we updated Format to use a Theme which can be a Pillar or something Special

[JamieB-gu]

Herculean refactor here, 💪

[JamieB-gu]

Interesting that this didn't previously throw an unused argument warning 🤔

[JamieB-gu]

Do we have somewhere where we can add a definition of what is the difference between Theme and Pillar?

Not sure if we have any documentation around this

It's a good point. We should probably put some markdown docs into the @guardian/types repo.

[JamieB-gu]

@webb04 you may find the conversation here useful for future work on this.