Set ASG creation policy

guardian · Jul 15, 2024 · 00634fd · 00634fd
1 parent b63eaf3
commit 00634fd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/cdk/lib/__snapshots__/cdk-playground.test.ts.snap b/cdk/lib/__snapshots__/cdk-playground.test.ts.snap
@@ -114,6 +114,11 @@ Object {
   },
   "Resources": Object {
     "AutoScalingGroupCdkplaygroundASGD6E49F0F": Object {
+      "CreationPolicy": Object {
+        "AutoScalingCreationPolicy": Object {
+          "MinSuccessfulInstancesPercent": 100,
+        },
+      },
       "Properties": Object {
         "HealthCheckGracePeriod": 120,
         "HealthCheckType": "ELB",
@@ -192,6 +197,9 @@ Object {
         "AutoScalingReplacingUpdate": Object {
           "WillReplace": true,
         },
+        "AutoScalingScheduledAction": Object {
+          "IgnoreUnmodifiedGroupSizeProperties": true,
+        },
       },
     },
     "CertificateCdkplayground47FCF7D9": Object {

diff --git a/cdk/lib/cdk-playground.ts b/cdk/lib/cdk-playground.ts
@@ -8,6 +8,7 @@ import { GuFastlyLogsIamRole } from '@guardian/cdk/lib/constructs/iam';
 import type {
 	App,
 	CfnAutoScalingReplacingUpdate,
+	CfnCreationPolicy,
 	CfnStack,
 	CfnUpdatePolicy,
 } from 'aws-cdk-lib';
@@ -64,14 +65,14 @@ export class CdkPlayground extends GuStack {
 			updatePolicy: UpdatePolicy.replacingUpdate(),
 		});
 
-		const updatePolicy: CfnUpdatePolicy = {
-			autoScalingReplacingUpdate: {
-				willReplace: true,
-			} as CfnAutoScalingReplacingUpdate,
+		const createPolicy: CfnCreationPolicy = {
+			autoScalingCreationPolicy: {
+				minSuccessfulInstancesPercent: 100,
+			},
 		};
+
 		const asg = autoScalingGroup.node.defaultChild as CfnAutoScalingGroup;
-		// asg.desiredCapacity = '3';
-		asg.cfnOptions.updatePolicy = updatePolicy;
+		asg.cfnOptions.creationPolicy = createPolicy;
 
 		new GuCname(this, 'EC2AppDNS', {
 			app: ec2App,