Skip to content

Commit

Permalink
Merge pull request #2396 from guardian/an/ssl-policy-only-on-https
Browse files Browse the repository at this point in the history
Only set an SSL policy on HTTPS application listeners
  • Loading branch information
andrew-nowak authored Aug 1, 2024
2 parents 552aac7 + c7426d3 commit 56e2c79
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/perfect-hats-allow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@guardian/cdk": patch
---

Only set an SSL policy on HTTPS application listeners
2 changes: 1 addition & 1 deletion src/constructs/loadbalancing/alb/application-listener.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class GuHttpsApplicationListener extends GuAppAwareConstruct(ApplicationL
const mergedProps: GuApplicationListenerProps = {
port: certificate ? 443 : 8080,
protocol: certificate ? ApplicationProtocol.HTTPS : ApplicationProtocol.HTTP,
sslPolicy: SslPolicy.RECOMMENDED_TLS,
sslPolicy: certificate ? SslPolicy.RECOMMENDED_TLS : undefined,
...props,
certificates: certificate
? [
Expand Down

0 comments on commit 56e2c79

Please sign in to comment.