Merge pull request #1253 from guardian/aa-linter-rule

chore(linter rule): Fix valid constructor linting rule
guardian · May 11, 2022 · 5840385 · 5840385
2 parents 5ccb3c1 + 930cc77
commit 5840385
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/tools/eslint/rules/valid-constructors.js b/tools/eslint/rules/valid-constructors.js
@@ -3,7 +3,7 @@ RULES
 1. Private constructors don't get linted
 2. Must be 1, 2 or 3 parameters
 3. First parameter must be called scope
-4. First parameter must be of type GuStack or GuStackForInfrastructure
+4. First parameter must be of type GuStack
 5. If 2 parameters:
    - The second parameter must be called props
    - The second parameter must be a custom type
@@ -77,7 +77,7 @@ const lintParameter = (param, node, context, { name, type, allowOptional, allowD
 
 const scopeParamSpec = {
   name: "scope",
-  type: new RegExp("^(GuStackForInfrastructure|GuStack)$"),
+  type: "GuStack",
   allowOptional: false,
   allowDefault: false,
   position: "first",

diff --git a/tools/eslint/rules/valid-constructors.test.ts b/tools/eslint/rules/valid-constructors.test.ts
@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-unused-vars -- testing file */
 
-import type { GuStack, GuStackForInfrastructure } from "../../../src/constructs/core";
+import type { GuStack } from "../../../src/constructs/core";
 
 interface MyProps {
   name: string;
@@ -50,9 +50,3 @@ class PrivateConstructor {
     console.log(number);
   }
 }
-
-class InfraConstructor {
-  constructor(scope: GuStackForInfrastructure) {
-    console.log(scope);
-  }
-}