Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Magnite aka Rubicon prebid partner #1467

Merged
merged 16 commits into from
Jul 25, 2024
Merged

Conversation

deedeeh
Copy link
Contributor

@deedeeh deedeeh commented Jul 16, 2024

What does this change?

This PR adds Magnite, previously named Rubicon and that's the name used in docs, as a prebid bidder.

It includes:

  • accountId, siteId and zoneId as they are required for integration. Please check Rubicon prebid docs for more info.
  • Bump guardian/Prebid.js v8.52.0-1 for enabling Magnite bid adapter in our prebid.js fork Add Magnite as a bid adapter Prebid.js#149
  • 1% AB test to receive data and check if they are in the correct key/value pairs. You can opt-in by adding #ab-PrebidMagnite=variant at the end of the url.

Other related PRs to this work:

Here is the spreadsheet with all the info regarding ad-sizes, siteId and zoneId based on the different regions.

In CODE or PROD the commercial switch and the AB test switch must be on and you opt in the test and this is how you see rubicon as part of the prebid bidders in the commercial logger.

I was able to test the switch locally and in CODE but the AB test I tested it just in CODE as there is an issue with opt in client-side tests locally.

If you want to test locally checkout to this branch and comment out the logic related to && ab test so you can check the request and response for rubicon based on the commercial switch.

Screenshot 2024-07-23 at 12 42 30

Screenshot 2024-07-23 at 12 43 27

Note: Rubicon is the old bidder name but it's still used for the integration. Magnite is the current name so in the code you will see the two names as I am using rubicon when it is required for integration which is absolutely necessary for sending requests and getting responses and magnite is for anything else related to just our code. There will be an iteration/refactor in another PR to name everything in our codebase rubicon but we just need to get this out at the moment.

Why?

We would like to add magnite (rubicon) as a prebid bidder behind a 1% AB test.

Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: 952d54f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@deedeeh deedeeh changed the title Add prebid magnite as a bidder Integrate Magnite (Prebid partner) Jul 16, 2024
Copy link
Contributor

github-actions bot commented Jul 16, 2024

Ad load time test results

For consented, top-above-nav took on average 4650ms to load.
For consentless, top-above-nav took on average 2898ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@deedeeh deedeeh force-pushed the dina/add-prebid-magnite branch from 3af9fdf to 2f2f33e Compare July 18, 2024 09:08
@deedeeh deedeeh added the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 18, 2024
Copy link
Contributor

🚀 0.0.0-beta-20240718161329 published to npm as a beta release

To install the beta version, run one of the following commands in your project directory:

npm install @guardian/[email protected]
pnpm add @guardian/[email protected]
yarn add @guardian/[email protected]

@github-actions github-actions bot removed the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 18, 2024
@deedeeh deedeeh force-pushed the dina/add-prebid-magnite branch from aa85d26 to d0eabb4 Compare July 22, 2024 08:30
@deedeeh deedeeh added the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 22, 2024
Copy link
Contributor

🚀 0.0.0-beta-20240722160602 published to npm as a beta release

To install the beta version, run one of the following commands in your project directory:

npm install @guardian/[email protected]
pnpm add @guardian/[email protected]
yarn add @guardian/[email protected]

@github-actions github-actions bot removed the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 22, 2024
@deedeeh deedeeh added the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 23, 2024
Copy link
Contributor

🚀 0.0.0-beta-20240723091408 published to npm as a beta release

To install the beta version, run one of the following commands in your project directory:

npm install @guardian/[email protected]
pnpm add @guardian/[email protected]
yarn add @guardian/[email protected]

@github-actions github-actions bot removed the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 23, 2024
@deedeeh deedeeh added the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 23, 2024
Copy link
Contributor

🚀 0.0.0-beta-20240723105830 published to npm as a beta release

To install the beta version, run one of the following commands in your project directory:

npm install @guardian/[email protected]
pnpm add @guardian/[email protected]
yarn add @guardian/[email protected]

@github-actions github-actions bot removed the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 23, 2024
@deedeeh deedeeh added the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 23, 2024
Copy link
Contributor

🚀 0.0.0-beta-20240723112208 published to npm as a beta release

To install the beta version, run one of the following commands in your project directory:

npm install @guardian/[email protected]
pnpm add @guardian/[email protected]
yarn add @guardian/[email protected]

@github-actions github-actions bot removed the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jul 23, 2024
@deedeeh deedeeh changed the title Integrate Magnite (Prebid partner) Integrate Magnite aka Rubicon (Prebid partner) Jul 23, 2024
@deedeeh deedeeh changed the title Integrate Magnite aka Rubicon (Prebid partner) Integrate Magnite aka Rubicon prebid partner Jul 24, 2024
@deedeeh deedeeh marked this pull request as ready for review July 24, 2024 12:27
@deedeeh deedeeh requested a review from a team as a code owner July 24, 2024 12:27
Copy link
Member

@Jakeii Jakeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@deedeeh deedeeh merged commit 131043a into main Jul 25, 2024
13 checks passed
@deedeeh deedeeh deleted the dina/add-prebid-magnite branch July 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants