-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Magnite aka Rubicon prebid partner #1467
Conversation
🦋 Changeset detectedLatest commit: 952d54f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
3af9fdf
to
2f2f33e
Compare
🚀 To install the beta version, run one of the following commands in your project directory:
|
aa85d26
to
d0eabb4
Compare
🚀 To install the beta version, run one of the following commands in your project directory:
|
🚀 To install the beta version, run one of the following commands in your project directory:
|
🚀 To install the beta version, run one of the following commands in your project directory:
|
🚀 To install the beta version, run one of the following commands in your project directory:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
What does this change?
This PR adds Magnite, previously named Rubicon and that's the name used in docs, as a prebid bidder.
It includes:
accountId
,siteId
andzoneId
as they are required for integration. Please check Rubicon prebid docs for more info.#ab-PrebidMagnite=variant
at the end of the url.Other related PRs to this work:
Here is the spreadsheet with all the info regarding ad-sizes, siteId and zoneId based on the different regions.
In CODE or PROD the commercial switch and the AB test switch must be on and you opt in the test and this is how you see
rubicon
as part of the prebid bidders in the commercial logger.I was able to test the switch locally and in CODE but the AB test I tested it just in CODE as there is an issue with opt in client-side tests locally.
If you want to test locally checkout to this branch and comment out the logic related to
&&
ab test so you can check the request and response for rubicon based on the commercial switch.Note: Rubicon is the old bidder name but it's still used for the integration. Magnite is the current name so in the code you will see the two names as I am using rubicon when it is required for integration which is absolutely necessary for sending requests and getting responses and magnite is for anything else related to just our code. There will be an iteration/refactor in another PR to name everything in our codebase
rubicon
but we just need to get this out at the moment.Why?
We would like to add magnite (rubicon) as a prebid bidder behind a 1% AB test.