Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape fullstops with backslashes in regex for URL #1810

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Feb 20, 2025

What does this change?

Updates URL used in Playwright test to match on exact URL by escaping the fullstops used in the regex

Why?

Resolves a code scanning alert https://github.com/guardian/commercial/security/code-scanning/2

Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: 8de98af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cemms1 cemms1 changed the title Escape fullstops with backslashes in regex for url Escape fullstops with backslashes in regex for URL Feb 20, 2025
@cemms1 cemms1 marked this pull request as ready for review February 20, 2025 16:38
@cemms1 cemms1 requested a review from a team as a code owner February 20, 2025 16:38
Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4447ms to load.
For consentless, top-above-nav took on average 3558ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@cemms1 cemms1 merged commit d47b391 into main Feb 21, 2025
14 checks passed
@cemms1 cemms1 deleted the cemms1/resolve-code-quality-issue branch February 21, 2025 10:24
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @cemms1 1 minute and 27 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants