IE11 grid and flex bug #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWare
requested review from
GHaberis,
nicl,
SiAdcock and
sndrs
as code owners
AWare
changed the title
SiAdcock
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Wraps grid stuff with
@supports (display: grid)andgrid-template-areaswith strings.❌❌❌
✅✅✅
Also it fixes a weird IE11 flow bug that came out of that fix.
philipwalton/flexbugs#75 (comment)
Why?
𝟙
IE11 not applying grid directives.
⓶
IE11 adding a whole bunch of phantom whitespace.
𝟹
This PR is done now.
phantom whitespace