Remove Prebid Bidder Performance in Admin Frontend tools #27506
Conversation
deedeeh
changed the title
deedeeh
force-pushed
the
dina/remove-prebid-bidder-performance
branch
from
559aa67 to
f09358e
Compare
dev-build/conf/routes
Outdated
| @@ -274,7 +274,6 @@ GET /commercial/non-refreshable-line-items.json | |||
|
|
|||
| GET /ads.txt commercial.controllers.AdsDotTextViewController.renderTextFile() | |||
| GET /app-ads.txt commercial.controllers.AdsDotTextViewController.renderAppTextFile() | |||
| GET /commercial/prebid/revenue controllers.admin.commercial.TeamKPIController.renderPrebidDashboard() | |||
| POST /commercial/api/hb commercial.controllers.PrebidAnalyticsController.insert() | |||
There was a problem hiding this comment.
icydk there's also the /hb endpoint which powers this graph.
Of which there is a router, prebid and data platform aspect:
- https://github.com/guardian/platform/blob/362efa1eb6e5b4bbdbeecb48a9146abb5941a553/router/files/router.conf#L406
- https://github.com/guardian/Prebid.js/blob/9671a714e8b8a0229ca4f9581fb4150c8ba065b3/modules/guAnalyticsAdapter.js#L135
But we can follow up seperately
There was a problem hiding this comment.
I am leaning towards removing the /hb endpoint from routes and dev-build routes and all related things to PrebidAnalyticsController and like you said the other two aspects could be a follow up.
There was a problem hiding this comment.
The only issue with removing /hb in this PR is that we'd need to remove the call to /hb from our prebid fork first so the call does not error in the clients. Probably better to remove from prebid first and then from Frontend.
There was a problem hiding this comment.
I can do that in Prebid and have a ready PR to merge then merge this PR after so I don't have to create two PRs in Frontend. What I am trying to understand right now the Platform repo router conf has to be removed when during the process I mentioned, any ideas?
There was a problem hiding this comment.
Sure thats fine as long you don't mind putting this PR on hold. I think Router changes changes can go anytime after we stop sending the /hb request from the client.
So first:
prebid (no more requests to /hb)
Then as there are no more requests to /hb we can do an the following in any order:
router
Frontend
Ah yes we can do that! Thanks for pointing it out 👍🏼 |
deedeeh
force-pushed
the
dina/remove-prebid-bidder-performance
branch
from
9371ff4 to
73c4cd3
Compare
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (created by @deedeeh and merged by @emma-imber 12 minutes and 1 second ago)
|
|
Seen on FRONTS-PROD (created by @deedeeh and merged by @emma-imber 14 minutes and 11 seconds ago)
|
What does this change?
This PR removes the Prebid Bidder Performance from Performance section in Commercial tools which is found in admin Frontend tools.
The Commercial team is tidying up the Commercial tools in admin page and this is the first step towards it.
Related PRs guardian/Prebid.js#159 and https://github.com/guardian/platform/pull/1625
The merging order for the PRs as follows #27506 (comment)
Screenshots
Checklist