remove mailing address requirement for S+2024

guardian · Sep 9, 2024 · ad07d29 · ad07d29
1 parent 5b4e99e
commit ad07d29
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lambda/src/main/scala/pricemigrationengine/handlers/NotificationHandler.scala b/lambda/src/main/scala/pricemigrationengine/handlers/NotificationHandler.scala
@@ -335,7 +335,7 @@ object NotificationHandler extends CohortHandler {
       cohortSpec: CohortSpec,
       contact: SalesforceContact
   ): Either[NotificationHandlerFailure, SalesforceAddress] = {
-    def targetAddressMembership2023(
+    def testCompatibleEmptySalesforceAddress(
         contact: SalesforceContact
     ): Either[NotificationHandlerFailure, SalesforceAddress] = {
       (for {
@@ -348,9 +348,10 @@ object NotificationHandler extends CohortHandler {
     }
 
     MigrationType(cohortSpec) match {
-      case DigiSubs2023            => Right(SalesforceAddress(Some(""), Some(""), Some(""), Some(""), Some("")))
-      case Membership2023Monthlies => targetAddressMembership2023(contact)
-      case Membership2023Annuals   => targetAddressMembership2023(contact)
+      case DigiSubs2023            => testCompatibleEmptySalesforceAddress(contact)
+      case Membership2023Monthlies => testCompatibleEmptySalesforceAddress(contact)
+      case Membership2023Annuals   => testCompatibleEmptySalesforceAddress(contact)
+      case SupporterPlus2024       => testCompatibleEmptySalesforceAddress(contact)
       case _ =>
         (for {
           billingAddress <- requiredField(contact.OtherAddress, "Contact.OtherAddress")