-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh, did I cause this problem with the refactoring I did for v1.0
?
Changes look good, just a couple questions.
…xport # Conflicts: # src/format.ts # src/index.ts # src/ophan.ts # src/option.ts # src/result.ts # src/role.ts
Is this a breaking change ( |
would it be a patch? I don't think any exports have changed – will it affect anyone doing straight |
Is it a feature because you can now import some things as
It seems to be interchangeable with normal |
does this mean it's not a new feature? :) |
Ah but that worked fine for us because we're not using isolated modules. Whereas my understanding was that you added this in order to get new functionality for projects that are using isolated modules? Ultimately it probably doesn't matter that much 🤷♂️, I'm happy with either. |
yeah that's a good point. I reckon that counts as a feature. how are releases done? do I need to update this PR? |
also, did you see #38? |
In the past, if there's just a single small change we've bumped in the change PR (e.g. #30). For larger changes, or multiple PRs going into a single change, I've done a separate PR just to bump the version (e.g. #35). Following that we'll need a It would be nice if we could automate this at some point, although we'd have to overcome the issues discussed in the CS Infra group relating to permissions. I did a bit of research and I think it would be easy enough to create a manually triggered GH action that creates a version bump PR. I think we could probably also do GH releases with GH actions. |
would it be useful if I added |
Looks like it may cover the required steps that I outlined above. "Opens a prefilled GitHub Releases draft after publish" how does it do this bit? Does it require GH creds? |
opens the page in your default browser with the fields pre-filled |
What does this change?
explicitly exports types
Why?
getting errors using
--isolatedModules
Have we considered potential risks?
should be minimal because type exports became available in
3.8
, and this package depends on^3.8.3