Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error for default build instructions #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

csirianni
Copy link

Resolves #1.

The default build instructions include the following command:

cmake -DFAISS_ENABLE_GPU=OFF -DFAISS_ENABLE_PYTHON=OFF -DBUILD_TESTING=ON -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -B build

which results in the following error:

CMake Error in faiss/CMakeLists.txt:
  Target "faiss" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/acorn/build/_deps/nlohmann_json-src/include"

  which is prefixed in the build directory.


CMake Error in faiss/CMakeLists.txt:
  Target "faiss" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/acorn/build/_deps/nlohmann_json-src/include"

  which is prefixed in the build directory.Target "faiss"
  INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/acorn/build/_deps/nlohmann_json-src/include"

  which is prefixed in the source directory.

The solution, as proposed in #1, is to change the CMakeList.txt dependency
specified in target_include_directories(faiss PUBLIC ${nlohmann_json_SOURCE_DIR}/include) from PUBLIC to PRIVATE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake Error in faiss/CMakeLists.txt during run_simple_test.sh or build following README.md
1 participant