Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typing Issues #22

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Fix Typing Issues #22

merged 4 commits into from
Oct 28, 2024

Conversation

sidjha1
Copy link
Collaborator

@sidjha1 sidjha1 commented Oct 28, 2024

Fixes a bunch of type issues identified by mypy and bumps minimum python version to 3.10. Also introduced types.py which can keep track of types returned by lotus operations. There are still mypy errors in the models directory but a lot of the model code will undergo heavy rewrite anyways so leaving that for later. Once all the mypy issues are resolved I will add it to the CI.

@sidjha1 sidjha1 requested a review from liana313 October 28, 2024 02:51
@liana313 liana313 merged commit 8d61eb2 into main Oct 28, 2024
2 checks passed
@sidjha1 sidjha1 deleted the sid/typing branch November 6, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants