operator level cache #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidjha1
reviewed
Dec 27, 2024
lotus/sem_ops/sem_agg.py
Outdated
| @@ -14,6 +15,7 @@ def sem_agg( | |||
| partition_ids: list[int], | |||
| safe_mode: bool = False, | |||
| progress_bar_desc: str = "Aggregating", | |||
| use_operator_cache: bool = False, | |||
There was a problem hiding this comment.
High level question - should use_operator_cache be a parameter here or is it better off in Settings? I think there is an argument for the latter, since I see this pattern being used everywhere.
There was a problem hiding this comment.
putting it in settings is better I'd say. I can put it in settings
|
Looks pretty clean! Can we also add some tests to make sure that the behavior is as intended. |
sidjha1
reviewed
Dec 27, 2024
lotus/settings.py
Outdated
| @@ -13,6 +13,7 @@ class Settings: | |||
|
|
|||
| # Cache settings | |||
| enable_cache: bool = False | |||
There was a problem hiding this comment.
Can enable_cache be renamed to enable_messsage_cache so its clear what the distinction is
There was a problem hiding this comment.
yea I can do that
sidjha1
reviewed
Dec 27, 2024
lotus/cache.py
Outdated
|
|
||
| cached_result = model.cache.get(cache_key) | ||
| if cached_result is not None: | ||
| print(f"Cache hit for {cache_key}") |
There was a problem hiding this comment.
Use lotus.logger rather than prints.
sidjha1
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement operator level caching