Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelizing sem_agg and sem_top_k #66

Merged
merged 9 commits into from
Dec 26, 2024
Merged

Parallelizing sem_agg and sem_top_k #66

merged 9 commits into from
Dec 26, 2024

Conversation

dhruviyer
Copy link
Collaborator

@dhruviyer dhruviyer commented Dec 26, 2024 •
edited
Loading

Addressing #61

sidjha1
sidjha1 reviewed Dec 26, 2024
View reviewed changes
examples/op_examples/agg.py Outdated Show resolved Hide resolved
examples/op_examples/top_k.py Outdated Show resolved Hide resolved
lotus/settings.py Outdated Show resolved Hide resolved
lotus/sem_ops/sem_agg.py Outdated Show resolved Hide resolved
@dhruviyer
Copy link
Collaborator Author

@sidjha1 any thoughts why the Multimodality CI test is failing?

@sidjha1
Copy link
Collaborator

sidjha1 commented Dec 26, 2024

@sidjha1 any thoughts why the Multimodality CI test is failing?

The test is flaky, so I wouldn't worry about it. You can rerun the job and I think it should pass. I'd have to look a bit at the logs but I don't think it's related to your change.

@dhruviyer dhruviyer marked this pull request as ready for review December 26, 2024 20:22
@sidjha1
Copy link
Collaborator

sidjha1 commented Dec 26, 2024

Checked the logs for the multimodality test, I think its related to this PR actually

=========================== short test summary info ============================
FAILED .github/tests/multimodality_tests.py::test_topk_with_groupby_operation[gpt-4o-mini] - KeyError: 0
======== 1 failed, 3 passed, 3 skipped, 2 warnings in 75.59s (0:01:15) =========

@dhruviyer
Copy link
Collaborator Author

@sidjha1 fixed the failing test which was due to a bug in this PR, but that was failing for a different reason than my earlier comment. Looks like all tests are passing now.

sidjha1
sidjha1 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@sidjha1 sidjha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhruviyer dhruviyer merged commit 1ec4d8a into main Dec 26, 2024
6 checks passed
@dhruviyer dhruviyer deleted the parallelization branch December 26, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidjha1 sidjha1 sidjha1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruviyer @sidjha1