-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composable scaffolding for CoT #75
Open
dhruviyer
wants to merge
10
commits into
main
Choose a base branch
from
dhruviyer/cot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d providing examples and requiring the model to use CoT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
As part of building toward #50 I wanted to lay some ground work for working with CoT prompts and completions. As a start I implemented this for sem_filter and want to get some comments/feedback on the design before rolling it out to other operators.
At a high level, I am proposing a few changes:
Hence, the PR revamps the way the model prompt to require the model to fill out this template:
<Reasoning> Provide your reasoning here. {customer reasoning instructions} </Reasoning> <Answer> Provide your answer here. {custom answer instructions} </Answer>
Correspondingly, it also formats the CoT examples in this same template when provided by the user
filter_formatter()
function:As mentioned, mostly want to get feedback from the authors if this approach makes sense