Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added osx arm64 support #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

norman-abramovitz
Copy link

@norman-abramovitz norman-abramovitz commented Sep 1, 2022

Added support arm64 and tested with cf7 and upgraded to go 1.19

@piejanssens
Copy link

Is the current lack of Darwin arm64 support the cause for this?

cf install-plugin Targets -r CF-Community                               zsh   100  19:37:17 
Searching CF-Community for plugin Targets...
Plugin Targets 1.2.0 found in: CF-Community
Attention: Plugins are binaries written by potentially untrusted authors.
Install and use plugins at your own risk.
Do you want to install the plugin Targets? [yN]: y
Starting download of plugin binary from repository CF-Community...
 9.13 MiB / 9.13 MiB [======================================================================================================================================] 100.00% 0s
signal: segmentation fault
File is not a valid cf CLI plugin binary.
FAILED

@piejanssens
Copy link

@guidowb Can you review this one, please?

@weisensen
Copy link

Hi @piejanssens , @guidowb

I got same issue :
image

i061653@MacBookPro Downloads % cf install-plugin /Users/i061653/Downloads/cf-targets-plugin
Attention: Plugins are binaries written by potentially untrusted authors.
Install and use plugins at your own risk.
Do you want to install the plugin /Users/i061653/Downloads/cf-targets-plugin? [yN]: y
signal: segmentation fault
File is not a valid cf CLI plugin binary.
FAILED
i061653@MacBookPro Downloads % system_profiler SPSoftwareDataType SPHardwareDataType
Software:

System Software Overview:

  System Version: macOS 13.0.1 (22A400)
  Kernel Version: Darwin 22.1.0
  Boot Volume: Macintosh HD
  Boot Mode: Normal
  Computer Name: D42YFT6DF7
  User Name: I061653 (i061653)
  Secure Virtual Memory: Enabled
  System Integrity Protection: Enabled
  Time since boot: 3 days, 39 minutes

Hardware:

Hardware Overview:

  Model Name: MacBook Pro
  Model Identifier: MacBookPro18,1
  Model Number: MK183CH/A
  Chip: Apple M1 Pro
  Total Number of Cores: 10 (8 performance and 2 efficiency)
  Memory: 16 GB
  System Firmware Version: 8419.41.10
  OS Loader Version: 8419.41.10
  Serial Number (system): D42YFT6DF7
  Hardware UUID: 8D16055B-7CFA-53C5-996C-9F925833AFE0
  Provisioning UDID: 00006000-001818621AD2801E
  Activation Lock Status: Disabled

@norman-abramovitz
Copy link
Author

norman-abramovitz commented Dec 8, 2022 via email

@piejanssens
Copy link

osx-arm64 build: cf-targets-plugin.zip

$ cf install-plugin cf-targets-plugin
Attention: Plugins are binaries written by potentially untrusted authors.
Install and use plugins at your own risk.
Do you want to install the plugin cf-targets-plugin? [yN]: y
Installing plugin cf-targets...
OK

Plugin cf-targets 1.2.0 successfully installed.

@norman-abramovitz
Copy link
Author

Is there a way to get this change merged or request any additional changes to complete the integration so that the osx arm plugin is also available?

@piejanssens
Copy link

@guidowb would you be willing to hand over the repo or move this to an org?

@norman-abramovitz
Copy link
Author

@piejanssens
I forked my repo to cloudfoundry community and made releases of the binaries there. I have yet to contact the maintainers of cli-plugin-repo to find out how to deal with what seems to be abandoned repos.

pin github.com/vito/go-interact to 1.0.0 so we can build from clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants