Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beredos2 patch 1 #7

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Beredos2 patch 1 #7

wants to merge 8 commits into from

Conversation

Beredos2
Copy link

@Beredos2 Beredos2 commented Feb 7, 2024

Uploaded a basic Simulink architecture that will be used for the insides of the Thermal calculation. I also changed the name of that file to fit the naming scheme better. Future work will be carried out in the Thermal branch. Requesting pull to get rid of my personal branch :D

The first model to fill the insides of the Thermal block. The aim is to use the thermal balance equation to calculate the average temperature of the spacecraft as a black-body.
Renamed to fit the standard naming scheme
@chgio chgio self-requested a review March 16, 2024 10:26
@chgio chgio force-pushed the Beredos2-patch-1 branch from 9f6f4ed to 98d740a Compare March 16, 2024 11:43
extract sources of radiation (Solar, Albedo, Planetary) into referenced
subsystems, and create new directory structure for all the new files

close #3
Copy link
Member

@chgio chgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know much about the maths so I'll just say it looks good to me and move on to the architecture. Good to close #3 though!

I turned all your subsystems into subsystem references and moved them to a neat subsystems/thermal subdirectory -- apart from the $A_{eff}$ calculator, which is in common.
I recommend this approach as it should make it easier to track and manage changes.

On this topic, as the Heat Balance Equation only takes in the orbital parameters to feed them into the $A_{eff}$ calculator, it would perhaps make more sense to move it out and feed its outputs into the Heat Balance Equation instead -- but I'll let you be the judge of that.
Feel free to pick whichever is more convenient, and know you can always refactor it :)

The nature of these orbital parameters needs more definition though.
In #1 we defined the Thermal subsystem model to require attitude and position as inputs, but the $A_{eff}$ calculator takes in attitude and orbital parameters.
Are these the vectors contained in your comment to #2, or other quantities required to calculate them? If they're anything but just the spacecraft's position, then we should update the ICD as this change would impact other subsystems and the top-level model.
Also, the content of the $A_{eff}$ calculator itself is still to-do (#2).

Giorgio Ciacchella and others added 2 commits March 16, 2024 12:22
Copy link
Author

@Beredos2 Beredos2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes accidentally made to the main branch. Please reject push @chgio . I don't seem to have the authority to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants