-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beredos2 patch 1 #7
base: main
Are you sure you want to change the base?
Conversation
The first model to fill the insides of the Thermal block. The aim is to use the thermal balance equation to calculate the average temperature of the spacecraft as a black-body.
Renamed to fit the standard naming scheme
also swap mismatched ports, even though inconsequential ref #2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know much about the maths so I'll just say it looks good to me and move on to the architecture. Good to close #3 though!
I turned all your subsystems into subsystem references and moved them to a neat subsystems/thermal
subdirectory -- apart from the common
.
I recommend this approach as it should make it easier to track and manage changes.
On this topic, as the Heat Balance Equation only takes in the orbital parameters to feed them into the
Feel free to pick whichever is more convenient, and know you can always refactor it :)
The nature of these orbital parameters needs more definition though.
In #1 we defined the Thermal subsystem model to require attitude and position as inputs, but the
Are these the vectors contained in your comment to #2, or other quantities required to calculate them? If they're anything but just the spacecraft's position, then we should update the ICD as this change would impact other subsystems and the top-level model.
Also, the content of the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes accidentally made to the main branch. Please reject push @chgio . I don't seem to have the authority to.
Uploaded a basic Simulink architecture that will be used for the insides of the Thermal calculation. I also changed the name of that file to fit the naming scheme better. Future work will be carried out in the Thermal branch. Requesting pull to get rid of my personal branch :D