Allow for punctuation, special characters, etc in Job Name #211
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A video preview as well of the changes: Screen.Recording.2025-01-20.at.9.13.53.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow for special characters in Job Names, which would fix the following issues:
#204
#144
This allows the Job Name to contain (what I have tested) the following characters at least:
Basically, any of the following, while still allowing the tab to function as expected.
Additionally, still allows multiple companies of the same name and different date values.
Let me know if you would like any changes @gurusabarish , though this is a very simple PR for a rather largely annoying but simple issue.