Skip to content

Commit

Permalink
Notes against party stats
Browse files Browse the repository at this point in the history
  • Loading branch information
3vcloud committed Jan 6, 2024
1 parent b9be2f4 commit 022b2c7
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion GWToolboxdll/Windows/PartyStatisticsWindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,18 @@ namespace {
});
return found != party_members.end() ? *found : nullptr;
}

PartyMember* GetPartyMemberByEncName(const wchar_t* enc_name)
{
/*
@Cleanup:
- What happens when 3 players each bring the same hero ? "Ebon Vanguard Mesmer" x 2
- GW sometimes sends the enc_name packet after the NPC is created; would this affect henchmen?
- Players can have names that match heros or henchmen in some edge cases
- Obfuscator could be a problem
Instead maybe hook into the PartyPlayerAdd / PartyAllyAdd / PartyHeroAdd packets, then identify by player owner / hero id instead of just using name
*/

if (pending_party_members)
return nullptr;
const auto found = std::ranges::find_if(party_members, [enc_name](const auto party_member) {
Expand Down

0 comments on commit 022b2c7

Please sign in to comment.