User-specified alternate answer separator #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added answerSeparator option; updated description to reflect the availability of the option
Add reference to answerSeparator parameter (86 and 725).
Update minorVersion to 13
Update patch version
Change self.params.answerSeparator to this.params.answerSeparator
|
@davidjabon Just noticed this pull request: You'll have to update translation files as well when you change labels in semantics.json or if you add fields to it. H5P-CLI can help you with that. I am not a member of the H5P core team, but they'd most likely request this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue with the blanks content type is that the answer separator is required to be forward slash (/). This requirement means that answers that need forward slashes (like fractions, for mathematics instruction) are not possible. Through a few very minor changes in the codebase, I propose a version that leaves the forward slash in place as a default but allows users to specify an alternate answer separator. This is a non-breaking change. An alternative would be some kind of escape character, but that is not implemented here. I propose this as a conservative but very helpful improvement.