clap-v4 support for hab cli
#9330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-habitat processing.
|
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
612cb36 to
9c7ee0e
Compare
|
CHEF-14734 |
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
d4f79d7 to
85003b9
Compare
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
88721b2 to
bd42815
Compare
mwrock
reviewed
Jan 7, 2025
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
bd42815 to
ae3bf2e
Compare
mwrock
reviewed
Jan 9, 2025
There was a problem hiding this comment.
This is just some minor but important textual issues in the option descriptions. Also as discussed in a standup call earlier, it would be great if we could deploy v2 and v4 together as long as that could be done without things getting too convoluted or otherwise horrible.
mwrock
reviewed
Jan 10, 2025
mwrock
reviewed
Jan 11, 2025
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
27276c1 to
e8b51d3
Compare
mwrock
approved these changes
Jan 14, 2025
Starting with some `cfg` trickery to make sure we continue to build old stuff. Very very experimental. Signed-off-by: Abhijit Gadgil <[email protected]> Moved `KeyType` into it's own module Signed-off-by: Abhijit Gadgil <[email protected]>
Initial skeleton for `hab pkg` command with Clap v4. This functionality gets enabled only with `v4` feature (off by default). Thus we continue to work with existing functionality. - Initial implementation of `hab pkg binds` - Initial implementation of `hab pkg binlink` - Initial implementation of `hab pkg path` - Initial implementation of `hab pkg build` - Added `hab pkg config` command - Added `hab pkg env` command - Added `hab pkg hash` command - Added `hab pkg header` command - Added `hab pkg info` command - Added `hab pkg verify` command Support for `pkg add bulkupload` command Also fixed issue with building on macos due to `#[cfg(....)]` in `do_build`. Implementation of `hab pkg delete` command Removed the `hab bldr job` from `main_v2` - Implemented `hab pkg channels` command - Implemented `hab pkg demote` command - Implemented `hab pkg dependencies` command - Implemented `hab pkg download` command - Implemented `hab pkg promote` command Implementation of `hab pkg list` command Making `v2` or `v4` as default - `hab pkg exec` - `hab pkg export` - `hab pkg provides` - `hab pkg search` - `hab pkg sign` - `hab pkg upload` - Added `hab pkg install` - Added `hab pkg uninstall` All `hab pkg ...` commands completed Signed-off-by: Abhijit Gadgil <[email protected]>
1. Added Unit tests for `AuthToken` APIs we are using 2. Added Unit tests for `BldrUrl` APIs we are using 3. Added Unit tests for `PkgDownloadOptions` This covers unit tests for *new* logic we have written during the porting activities. Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
When exporting a package, if the given package does not exist in the specified channel (or default channel) we were unwrapping an error, rather than properly returning it. Signed-off-by: Abhijit Gadgil <[email protected]>
Rebase with origin/main fix conflicts Support for refresh channel and `FEATURE_LOCAL` was missing during rebase added that support to both CLI v2 and CLI v4. `HabPkgIdentValueParser` validator was not used for `PackageIdent` which is a struct field in many of the `pkg` commands. Started using it. Fixed String to Pathbuf and String to PackageIdent conversions in the validators Removed the unused CF and Mesos exporters. Signed-off-by: Abhijit Gadgil <[email protected]>
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
e8b51d3 to
79eac74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with some
cfgtrickery to make sure we continue to build old stuff. Very very experimental.