Read Sphinx output and create struct #36
Conversation
…iption-service into run-sphinx-command-line Merging in remote changes
…e4all into ibm-websockets
…into run-sphinx-command-line
…into new-config
config working
Basic UI for starting a job
…into anosha-read-json-file-to-struct
…into ibm-websockets
Hook app together and add logging
Annotate errors with stack trace information
Added actual sessions
Errors are handled with email now
Task executer now expires task information to avoid memory leaks
|
@sandlerben Addressed comments, also I thought I addressed conflicts but apparently not. When I call 'git merge origin/master' it says everything is up to date - what else do I need to do? |
|
Did you fetch first? On Thu, May 19, 2016, 7:35 PM Anosha Minai [email protected] wrote:
|
|
Also I think the account situation is a little messed up I'll fix it later. On Thu, May 19, 2016, 8:35 PM hack4impactadmin [email protected]
|
|
@sandlerben Okay all fixed! I moved the Sphinx stuff into a sphinx.go folder, I need to add the MakeSphinxTaskFunction method but I will do that in a separate PR. Let me know what you think and then I'll merge. |
|
|
||
| // SphinxTranscription transcribes a given file using Sphinx. | ||
| // File name should not include the type extension. | ||
| func SphinxTranscription(fileName string) (Transcription, error) { |
There was a problem hiding this comment.
Change to TranscribeWithShinx?
There was a problem hiding this comment.
fileNamefilePath to be consistent with other code
|
Added a few comments, besides that lgtm |
@sandlerben @roornelas
This PR is an extension of #26 - the function to run the command is now fixed in this PR, but I can also fix it in #26 if that's less confusing. There are two main new things: 1) StartTranscription runs a command and returns a string which is the output file name where the output is stored and 2) the func transcriptionOutputToStruct was created which reads a file (with the output) and creates a go struct.