Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menu for hidden nav items #77

Merged
merged 12 commits into from
Jan 16, 2025
Merged

Conversation

seandreassen
Copy link
Member

Added menu to access pages that aren't in the main navigation component in the header. Also added button to go to matrix and moved internal navigation links into a separate component.

Closes #74

@seandreassen seandreassen added the enhancement New feature or request label Nov 21, 2024
@seandreassen seandreassen self-assigned this Nov 21, 2024
@seandreassen seandreassen linked an issue Nov 21, 2024 that may be closed by this pull request
src/components/layout/Header.tsx Show resolved Hide resolved
src/components/layout/header/DarkModeMenu.tsx Outdated Show resolved Hide resolved
src/components/layout/header/DesktopNavMenu.tsx Outdated Show resolved Hide resolved
src/components/layout/header/LocaleMenu.tsx Outdated Show resolved Hide resolved
src/components/layout/header/MatrixButton.tsx Outdated Show resolved Hide resolved
src/components/layout/header/Nav.tsx Outdated Show resolved Hide resolved
@michaelbrusegard
Copy link
Member

michaelbrusegard commented Jan 10, 2025

Few things to note:

Good job, looks lovely! Go ahead and merge

@seandreassen seandreassen requested a review from MoaKK January 13, 2025 15:26
@michaelbrusegard
Copy link
Member

@seandreassen can this be merged soon?

Copy link

@MoaKK MoaKK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together in person. Looks good imo, good job!

@michaelbrusegard
Copy link
Member

Ok merge when you want!

@seandreassen seandreassen merged commit ee37f77 into dev Jan 16, 2025
3 checks passed
@seandreassen seandreassen deleted the create-menu-for-hidden-nav-items branch January 16, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the desktop menu for hidden nav items
3 participants