Edit to "Issue Trigger" workflow to exclude closed issues from assignee checks

[t-will-gillis]

Fixes #7771

What changes did you make?

• Added case to check-complexity-eligibility.js to check whether the issue is closed

Why did you make the changes (we will use this info to test)?

• If the issue is closed, the 'check complexity eligibility' function should halt
• Added comments to clarify what the workflow is doing

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

• I have checked this PR for CodeQL alerts and none were found.
• I found CodeQL alert(s), and (select one):
  • I have resolved the CodeQL alert(s) as noted
  • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
  • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

• No visual changes to website
• Website run from test branch

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-edit-assign-closed-issue-to-member-7771 gh-pages
git pull https://github.com/t-will-gillis/website.git edit-assign-closed-issue-to-member-7771

[FamousHero]

Review ETA: 1/15/2025
Availability: Tuesday & Saturday 8-9pm

[iancooperman]

Review ETA: 1/17/2025
Availability: Weekdays (except Thursday) - 5pm to 6:30pm, 8pm to 9pm; Thursday - 8pm to 9pm

[t-will-gillis]

Hey @FamousHero and @iancooperman I did not leave any notes about testing for this PR- which I should have. Let me know if either of you would like notes for any part of this. Also, please leave a message if you get some error that isn't obvious. I might have seen it before and could save you time.

Besides setting up a copy of the HfLA Project Board and the tokens, you will need to change github-actions/utils/get-team-members.js line 16 to org: <your github handle> SHOULD BE org: 'hackforla',

[mugdhchauhan]

Review ETA: 24 Jan 2025 @ 8 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

[mugdhchauhan]

Hey @t-will-gillis, thanks for making this PR.

I'm using this guide.

When I'm attempting to create my own Project Board I am getting this error:

I do not have a Project Board that is already copied to my forked repo. I would greatly appreciate your help on this.

[Cloid]

Review ETA: 1/22 @ 8 PM (PST)
Availability: 6pm-8pm (PST)

[t-will-gillis]

Hi @iancooperman @FamousHero @mugdhchauhan @Cloid

FYI I am changing this PR to Complexity: Large. The actual change from this PR is minor, however, in order to test the change you need to have a working test environment on your repo, and that in itself is a "Large" undertaking. You probably will want to wait for another PR If you are looking for a "Small" one to review.

If anyone is interested in learning GitHub Actions there will be easier PRs to review (including #7777)- and there are also several GHA issues coming up that you will be able to work on. (These are listed on #6454 and are awaiting Bonnie's approval). Information about GHAs are here: Hack for LA's GitHub Actions, latest revision. See Tips 6,7, and 8 especially if you want to set up your own environment

One last thing, I will be happy to do a live demonstration of the changes I made with this PR if that is helpful. On past PRs we have done approvals based on a live demo rather than on having the reviewers each recreate the test environment. Let me know what you think.

[mugdhchauhan]

Hey @t-will-gillis, thank you for working on this and helping me. I managed to set up a working test environment on my repo and resolve the errors I was facing.

Kudos

• The pull request is made with the correct branch.
• All sections of the PR post are complete.
• The originating issue (Edits to "Issue Trigger" workflow, check-complexity-eligibility.js #7771) is assigned and added to the "In progress (actively working)" column.

Suggested Changes

• In the screenshot below, when testing it can be seen that it still removes assignment even though the issue is closed. This could be fixed.
• In the originating issue under "Resources/Instructions" you could add what is stated for "REPLACE THIS TEXT" to complete this section.
• Provide availability and ETA in the originating issue. (You may not have to do this as it is marked as hidden as resolved.)

Screenshot

Once again, many thanks. Please could you re-request a review from me after the changes have been made. I am happy to help.