fix/prevent trimming stream after removed #24
Merged
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a possibility that the stream would be deleted before
xTrim
is called. When persisting in worker, a promise is created and would resolve once the worker is done processing persisting.Where this line would be called:
y-socketio-redis/src/y-socket-io/y-socket-io.js
Line 680 in e85b438
Before this line:
y-socketio-redis/src/y-socket-io/y-socket-io.js
Line 539 in e85b438
Due to here also waiting on the same promise:
y-socketio-redis/src/y-socket-io/y-socket-io.js
Line 659 in e85b438
In this PR, we check if the namespace still exists before calling on the trim function. The namespace is deleted here:
y-socketio-redis/src/y-socket-io/y-socket-io.js
Line 678 in e85b438
Just before deleting the stream, so we can assume the stream still exists in Redis if the namespace is still alive.