Rebase of #1040, do not merge to main #1070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhess
force-pushed
the
dhess/typedef-actions-tests
branch
from
41ee2a9 to
09734ce
Compare
This will be necessary when we extend to typedefs, since we need to branch here, but can't use `label` in `GenT`. Signed-off-by: George Thomas <[email protected]>
This should have been done back when `forDef` etc. acquired their current names. Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
we never consistently checked these things in `applyProgAction`, and it would be awkward to do so. besides, why do we care? Signed-off-by: George Thomas <[email protected]>
-- TODO rename `updateType` to `updateTypeDef` and this to `updateType`? in all branches? Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
…w fails for different reason Signed-off-by: George Thomas <[email protected]>
I now understand your comment about needing the local cxt! I don't know why it was implemented in this way in the first place, and it seems rather silly given that we now (I changed this a few commits ago) extract the cached chkedAt type below! Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
this wasn't actually due to test failures, just something I noticed in passing - perhaps we should tweak generators to try to exercise this sort of thing more? Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
Signed-off-by: Drew Hess <[email protected]>
dhess
force-pushed
the
dhess/typedef-actions-tests
branch
from
09734ce to
8487cfa
Compare
dhess
added a commit
to hackworthltd/primer-app
that referenced
this pull request
Jun 11, 2023
We bump the Primer pin (still running off hackworthltd/primer#1070, FYI) and bump the eval step limit to 300. Signed-off-by: Drew Hess <[email protected]>
|
@brprice Would you mind picking this PR up and getting it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rebase of #1040 on current main, so that I can deploy it. (#1040 lacks the necessary GitHub workflow to do this, and I didn't want to touch that PR.)