Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add a preliminary Haskell style guide. #991

Merged
merged 1 commit into from
May 16, 2023
Merged

doc: Add a preliminary Haskell style guide. #991

merged 1 commit into from
May 16, 2023

Conversation

dhess
Copy link
Member

@dhess dhess commented May 15, 2023

Closes #143

@dhess
Copy link
Member Author

dhess commented May 15, 2023

I believe this addresses everything that we wrote in #143, and more. Comments & suggested additions welcome.

@dhess dhess requested a review from a team May 15, 2023 14:30
@dhess
doc: add a Haskell style guide
95ba991 
Closes #143

Signed-off-by: Drew Hess <[email protected]>
@dhess dhess force-pushed the dhess/style-guide branch from ece4d74 to 95ba991 Compare May 16, 2023 22:09
@dhess
Copy link
Member Author

dhess commented May 16, 2023

I'm going to merge this now. It's easy enough to fix up later if anyone would like to make additional changes.

@dhess dhess added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit 21c7fa7 May 16, 2023
@dhess dhess deleted the dhess/style-guide branch May 16, 2023 22:29
georgefst
georgefst reviewed May 17, 2023
View reviewed changes
docs/haskell-style-guide.md

## Cabal

* Start all new Cabal projects with `default-language: Haskell2010`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems odd in light of the fact that all of our default-language fields are currently set to GHC2021.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's an oversight. I'll fix it, thanks.

@dhess
Copy link
Member Author

dhess commented May 17, 2023

Fixes can go here: #997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgefst georgefst georgefst left review comments

@brprice brprice brprice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Haskell style guide
3 participants
@dhess @brprice @georgefst