Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebiten: add RunGameOptions.StrictContextRestoration to use internal/restorable as an optional feature #3083

Closed
1 of 11 tasks
hajimehoshi opened this issue Sep 6, 2024 · 4 comments
Closed
1 of 11 tasks

ebiten: add RunGameOptions.StrictContextRestoration to use internal/restorable as an optional feature #3083

hajimehoshi opened this issue Sep 6, 2024 · 4 comments
Labels
bug os:android
Milestone
v2.8.0

Comments

@hajimehoshi
Copy link
Owner

hajimehoshi commented Sep 6, 2024 •
edited
Loading

Ebitengine Version

v2.8.0-alpha.3

Operating System

  • Windows
  • macOS
  • Linux
  • FreeBSD
  • OpenBSD
  • Android
  • iOS
  • Nintendo Switch
  • PlayStation 5
  • Xbox
  • Web Browsers

Go Version (go version)

go version go1.22.6 darwin/arm64

What steps will reproduce the problem?

Submit an Android application and see prelaunch reports

What is the expected result?

No error

What happens instead?

There are some errors.

This error sometimes happens in the prelaunch report (google Pixel 5 64-bit only), and also in the real world (Android vitals)

  #00  pc 0x0000000000052a64  /apex/com.android.runtime/lib64/bionic/libc.so (__memcpy_aarch64_simd+36)
  #01  pc 0x000000000017871c  /vendor/lib64/egl/libGLESv2_adreno.so (!!!0000!77df12deb6a622478efa8fb9929034!4783c89!+1212)
  #02  pc 0x000000000077f9c8  /data/app/~~QGOUdPYjXO_FBwGrhte-pA==/com.rpgsnack.tsugunai-zPiYGBu1D1mPh_UdnnjB1A==/split_config.arm64_v8a.apk

This error happens when resizing a window in an Android desktop emulator (Generic Small Desktop (x86) (virtual))

  #00  pc 0x0000000000057d51  /vendor/lib64/libGLESv2_enc.so (GL2Encoder::calcIndexRange(void const*, unsigned int, int, int*, int*)+609)
  #01  pc 0x000000000003dd30  /vendor/lib64/libGLESv2_enc.so (GL2Encoder::s_glDrawElements(void*, unsigned int, int, unsigned int, void const*)+832)
  #02  pc 0x000000000077b720  /data/app/~~EK_pBBRAksFg2bglyGOCaA==/com.rpgsnack.tsugunai-IznR2H8Wmy2OizfErqfZvA==/split_config.x86_64.apk

In order to fix them, I think we should revive internal/restorable unfortunately.

Anything else you feel useful to add?

internal/restorable was removed at #805
@hajimehoshi hajimehoshi added the bug label Sep 6, 2024
@hajimehoshi hajimehoshi added this to the v2.8.0 milestone Sep 6, 2024
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate the implementation into intern…
dc8922f 
…al/atlas"

This reverts commit c404b44.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: remove Image"
fd0b677 
This reverts commit 812cd49.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate the implementation into intern…
452227a 
…al/atlas"

This reverts commit c404b44.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: remove Image"
3f747ce 
This reverts commit 812cd49.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image functions into internal/…
aaba6a6 
…atlas"

This reverts commit 59896e4.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.Extend into internal/atlas"
b6636fe 
This reverts commit 6151fd3.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.WritePixels into interna…
96778bc 
…l/atlas"

This reverts commit 6cc8150.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.DrawTriangles into inter…
4f06b7b 
…nal/atlas"

This reverts commit 3ee905b.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Shader.Dispose into internal/a…
bc334e1 
…tlas"

This reverts commit bfa2c46.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: refactoring"
aebe41c 
This reverts commit 81e1104.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate ReadPixels into internal/atlas"
309fe97 
This reverts commit e804f9e.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: remove ImageType"
a273091 
This reverts commit 21ef462.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/atlas: move some functions in internal/restorable to…
f208b40 
… internal/atlas"

This reverts commit 3651d73.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: move SwapBuffers to internal/atlas"
0bed4aa 
This reverts commit f610cb5.

Updates #3083
@hajimehoshi
Copy link
Owner Author

hajimehoshi commented Sep 6, 2024 •
edited
Loading

Note to myself: I'm not sure I should revert 5a36b4b. IIUC, this is not needed for Android where you can detect context loss easily. See also a30f075

hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/atlas: refactoring: remove ImageTypeVolatile"
1a0b986 
This reverts commit def82fd.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate the implementation into intern…
f072776 
…al/atlas"

This reverts commit c404b44.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: remove Image"
fd61f63 
This reverts commit 812cd49.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image functions into internal/…
4c11d2a 
…atlas"

This reverts commit 59896e4.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.Extend into internal/atlas"
7bc2242 
This reverts commit 6151fd3.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.WritePixels into interna…
ab781b2 
…l/atlas"

This reverts commit 6cc8150.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.DrawTriangles into inter…
3ab0b2b 
…nal/atlas"

This reverts commit 3ee905b.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate Shader.Dispose into internal/a…
3a11b27 
…tlas"

This reverts commit bfa2c46.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: refactoring"
868402e 
This reverts commit 81e1104.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: integrate ReadPixels into internal/atlas"
8a1c56a 
This reverts commit e804f9e.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/restorable: remove ImageType"
97ce858 
This reverts commit 21ef462.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 6, 2024
@hajimehoshi
Revert "internal/atlas: move some functions in internal/restorable to…
00a1357 
… internal/atlas"

This reverts commit 3651d73.

Updates #3083
@hajimehoshi
Copy link
Owner Author

hajimehoshi commented Sep 6, 2024 •
edited
Loading

Note to myself: I found appendRegionRemovingDuplicates is pretty heavy.

This was introduced at 367606f and optimized at cc24796, and this is still heavy. I think I'll remove them.

Related

@hajimehoshi
Copy link
Owner Author

In order to mitigate risk of performance regression, I have to add a feature to switch restoring or not.

@hajimehoshi hajimehoshi changed the title revive internal/restorable revive internal/restorable as an optional feature Sep 6, 2024
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/atlas: refactoring: remove ImageTypeVolatile"
81c75e1 
This reverts commit def82fd.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: integrate the implementation into intern…
0b01aee 
…al/atlas"

This reverts commit c404b44.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: remove Image"
5a5feb0 
This reverts commit 812cd49.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image functions into internal/…
54c117b 
…atlas"

This reverts commit 59896e4.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.Extend into internal/atlas"
104cc18 
This reverts commit 6151fd3.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.WritePixels into interna…
d733308 
…l/atlas"

This reverts commit 6cc8150.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: integrate Image.DrawTriangles into inter…
17a5488 
…nal/atlas"

This reverts commit 3ee905b.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: integrate Shader.Dispose into internal/a…
19d2009 
…tlas"

This reverts commit bfa2c46.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: refactoring"
becada4 
This reverts commit 81e1104.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: integrate ReadPixels into internal/atlas"
d533461 
This reverts commit e804f9e.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: remove ImageType"
a324cfd 
This reverts commit 21ef462.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/atlas: move some functions in internal/restorable to…
c2c5480 
… internal/atlas"

This reverts commit 3651d73.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: move SwapBuffers to internal/atlas"
a9d8f37 
This reverts commit f610cb5.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: move DumpImages to internal/atlas"
169b9fe 
This reverts commit 7c9266d.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: remove ImageTypeRestorable"
34639d0 
This reverts commit 8c2d4e1.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: remove unnecessary functions and variabl…
6453e55 
…es around shaders"

This reverts commit 4f3e00e.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: remove unused functions and variables"
81d35df 
This reverts commit 8169253.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: remove alwaysReadPixelsFromGPU"
16d2052 
This reverts commit f320672.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: remove drawTrianglesHistoryItem"
5e18f19 
This reverts commit afe3f7a.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
Revert "internal/restorable: remove the case when the restoring is ne…
935e7a6 
…eded"

This reverts commit c08a219.

Updates #3083
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
ebiten: add RunGameOptions.StrictContextRestration
9e54eca 
This reverts commit a30f075.

This change adds a new option StrictContextRestration to make the
restoration optional.

Closes #3083
@hajimehoshi hajimehoshi changed the title revive internal/restorable as an optional feature ebiten: add RunGameOptions.StrictContextRestoration to use internal/restorable as an optional feature Sep 7, 2024
hajimehoshi added a commit that referenced this issue Sep 7, 2024
@hajimehoshi
internal/restorable: optimize removeDuplicatedRegions
d50a438 
Updates #2375
Updates #2626
Updates #3083
This was referenced Sep 9, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug os:android
Projects
None yet
Milestone
v2.8.0
Development

No branches or pull requests
1 participant
@hajimehoshi