-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates dice to use CommandModule #3
Open
mracine
wants to merge
1
commit into
halibot-extra:master
Choose a base branch
from
mracine:commandmod-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,30 @@ | ||
import random, re | ||
from halibot import HalModule | ||
from halibot import CommandModule, HalConfigurer | ||
|
||
die_re = re.compile("(\d+)[dD](\d+)") | ||
|
||
MAX_COUNT = 10 | ||
MAX_SIDES = 10000 | ||
|
||
class DiceModule(HalModule): | ||
class DiceModule(CommandModule): | ||
|
||
class Configurer(HalConfigurer): | ||
def configure(self): | ||
self.optionInt("max-count", prompt="Max number of dice to roll at once", default=MAX_COUNT) | ||
self.optionInt("max-sides", prompt="Max number of sides per die", default=MAX_SIDES) | ||
|
||
def roll(self, count, sides): | ||
def init(self): | ||
self.commands = { "roll": self.roll_ } | ||
|
||
def _roll(self, roll): | ||
m = re.match(die_re, roll) | ||
|
||
if not m: | ||
return self._err() | ||
|
||
count = int(m.group(1)) | ||
sides = int(m.group(2)) | ||
|
||
if count == 0: | ||
return "0" | ||
if count < 0: | ||
|
@@ -40,21 +51,17 @@ def roll(self, count, sides): | |
|
||
return response | ||
|
||
def receive(self, msg): | ||
coarse = msg.body.strip().split(" ") | ||
cmd = coarse[0] | ||
rolls = list(filter( lambda x: re.match(die_re, x), coarse[1:] )) | ||
def _err(self): | ||
return "You make a motion as if to roll some dice, but as you open your hands to throw them, only air escapes." | ||
|
||
if cmd == '!roll': | ||
if len(rolls) == 0: | ||
self.reply(msg, body="You make a motion as if to roll some dice, but as you open your hands to throw them, only air escapes.") | ||
return | ||
def roll_(self, string, msg=None): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This naming scheme is potentially confusing, having a function called |
||
args = string.strip().split(" ") | ||
|
||
for r in rolls: | ||
m = re.match(die_re, r) | ||
count = int(m.group(1)) | ||
sides = int(m.group(2)) | ||
if len(args) == 0: | ||
self.reply(msg, body=self._err()) | ||
return | ||
|
||
response = self.roll(count, sides) | ||
self.reply(msg, body=response) | ||
for r in args: | ||
response = self._roll(r) | ||
self.reply(msg, body=response) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
_err
for this function name is too generic, as there is at least one other error case when the number of sides is 0There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably makes more sense to make this a string constant anyway