Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dice to use CommandModule #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 24 additions & 17 deletions dice.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,30 @@
import random, re
from halibot import HalModule
from halibot import CommandModule, HalConfigurer

die_re = re.compile("(\d+)[dD](\d+)")

MAX_COUNT = 10
MAX_SIDES = 10000

class DiceModule(HalModule):
class DiceModule(CommandModule):

class Configurer(HalConfigurer):
def configure(self):
self.optionInt("max-count", prompt="Max number of dice to roll at once", default=MAX_COUNT)
self.optionInt("max-sides", prompt="Max number of sides per die", default=MAX_SIDES)

def roll(self, count, sides):
def init(self):
self.commands = { "roll": self.roll_ }

def _roll(self, roll):
m = re.match(die_re, roll)

if not m:
return self._err()

count = int(m.group(1))
sides = int(m.group(2))

if count == 0:
return "0"
if count < 0:
Expand All @@ -40,21 +51,17 @@ def roll(self, count, sides):

return response

def receive(self, msg):
coarse = msg.body.strip().split(" ")
cmd = coarse[0]
rolls = list(filter( lambda x: re.match(die_re, x), coarse[1:] ))
def _err(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think _err for this function name is too generic, as there is at least one other error case when the number of sides is 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably makes more sense to make this a string constant anyway

return "You make a motion as if to roll some dice, but as you open your hands to throw them, only air escapes."

if cmd == '!roll':
if len(rolls) == 0:
self.reply(msg, body="You make a motion as if to roll some dice, but as you open your hands to throw them, only air escapes.")
return
def roll_(self, string, msg=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This naming scheme is potentially confusing, having a function called _roll and another called roll_. Maybe roll_cmd for the second? I can be convinced otherwise though.

args = string.strip().split(" ")

for r in rolls:
m = re.match(die_re, r)
count = int(m.group(1))
sides = int(m.group(2))
if len(args) == 0:
self.reply(msg, body=self._err())
return

response = self.roll(count, sides)
self.reply(msg, body=response)
for r in args:
response = self._roll(r)
self.reply(msg, body=response)