Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update per elixir 1.4 deprecations #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

russmatney
Copy link
Contributor

Re: #125 – Replaces Dict usage with Keyword or Map where necessary, removing distracting compile time warnings.

@russmatney
Copy link
Contributor Author

Failing test seems to be caused by an expiring certificate:

1) test ssl connection (ConnectionTest)
     test/connection_test.exs:109
     ** (EXIT from #PID<0.1758.0>) an exception was raised:
         ** (CaseClauseError) no case clause matching: {:error, {:tls_alert, 'certificate expired'}}
             (rethinkdb) lib/rethinkdb/connection.ex:225: RethinkDB.Connection.connect/2
             (rethinkdb) lib/rethinkdb/connection.ex:215: RethinkDB.Connection.init/1
             (connection) lib/connection.ex:425: Connection.init_it/6
             (stdlib) proc_lib.erl:240: :proc_lib.init_p_do_apply/3

@hamiltop
Copy link
Owner

Hey thanks for taking a look at this. If you could update the travis config to use 1.4, and then get it passing on 1.3 I'm happy to merge this.

@russmatney
Copy link
Contributor Author

@hamiltop Seems to be passing on OTP 19.1 but failing on 18.3 - not sure why, will look into it hopefully later this weekend

@norpan
Copy link
Contributor

norpan commented Sep 27, 2017

Should probably have both elixir 1.3 and 1.4 in travis (and 1.5?) as well the latest versions of OTP 18, 19 and 20

@norpan
Copy link
Contributor

norpan commented Apr 2, 2018

Current master seems to not work with all combinations, or maybe there are intermittent errors. Needs checking before relying on travis testing for different versions. See #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants