Use JDK 17 syntax #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JValue is now a real sealed interface Use records for implementations of JValue except for JNull which is an enum Change fold to use a Visitor instead Printer is now simpler, most logic is now within the folder, should allow us to have multiple implementors of state.
hamnis
commented
Sep 12, 2024
| if (o == null || getClass() != o.getClass()) return false; | ||
| JString jString = (JString) o; | ||
| return Objects.equals(value, jString.value); | ||
| default String scalarToString() { |
There was a problem hiding this comment.
we could move this to implementation classes to avoid throwing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JValue is now a real sealed interface
Use records for implementations of JValue except for JNull which is an enum
Change fold to use a Visitor instead
Printer is now simpler, most logic is now within the folder, should allow us to have multiple implementors of state.