Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Priority with Known+Unknown cards #1216

Closed
wants to merge 2 commits into from

Conversation

english5040
Copy link
Contributor

No description provided.

@Zamiell
Copy link
Collaborator

Zamiell commented Jul 22, 2024

I'll have ADrone take a look at this PR, since he was in charge of the last priority change/clarification

@EhDrone
Copy link
Contributor

EhDrone commented Jul 23, 2024

I might be missing something - but you updated it to describe the opposite scenario of what the section is trying to explain. Sorry if I am reading it wrong -- but the point of that section is to let people know that playing an Unknown card instead of the known card, but you updated the section to describe playing a known card over an unknown card.

@english5040
Copy link
Contributor Author

english5040 commented Jul 23, 2024

There are two cases the original was trying to describe: when does playing an unknown over a known cause a PF and when does playing known over unknown cause a PF. In the first case that generally does nothing, and the second case is the important one to discuss, wherein the orig. doc was confusingly phrased

The orig. doc was trying to say that the known has to have lower priority than all unknown superpositions but said it badly and reversed it

@english5040
Copy link
Contributor Author

additionally, according to the priority table, the original examples were invalid, so I changed them to reflect the current priority table

@english5040
Copy link
Contributor Author

hm, I can rephrase some of the wording, I think

@english5040
Copy link
Contributor Author

there we go, now it's all about whether the known has strictly lower priority than the unknown identities

@english5040
Copy link
Contributor Author

This PR is now obsolete after a discussion with ADrone; it reflected a common interpretation of the priority table which was not the intended meaning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants