Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update level-12.mdx to add something about optional prio. #1271

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

gw12346
Copy link
Contributor

@gw12346 gw12346 commented Nov 16, 2024

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for hanabi-test ready!

Name Link
🔨 Latest commit 1ef8c5b
🔍 Latest deploy log https://app.netlify.com/sites/hanabi-test/deploys/673ba2f441d2880008e9027b
😎 Deploy Preview https://deploy-preview-1271--hanabi-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zamiell
Copy link
Collaborator

Zamiell commented Nov 17, 2024

can you explain why you are moving the "General Principles" section in this PR?

@gw12346
Copy link
Contributor Author

gw12346 commented Nov 17, 2024

In my experience, players learning level 12 are great at learning conventions (focus inversion and stale 1s) but some seemingly skim over "General Principles": stealing clues when they have multiple cards to play, unnecessarily saving cards they themselves hold, and giving clues other players can't build off of.

We're great at teaching players how to clue, but I wonder if we need more emphasis on whether to clue.

@Zamiell
Copy link
Collaborator

Zamiell commented Nov 18, 2024

all of the levels follow the same ordering, with general principles being at the end.
i dont think you can change the ordering in just one level and keep the ordering in all of the other levels the same, that would be introducing a bug.
if you want to do a major reordering change like that, then i think you first need to open an issue.
so for now please revert the reordering.
and in general, remember that your PRs should only be doing 1 thing at a time.

@Zamiell
Copy link
Collaborator

Zamiell commented Nov 18, 2024

see my updates, thanks

@Zamiell Zamiell merged commit f9f0932 into hanabi:main Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants