Collision Test Fix #746
Merged
Collision Test Fix #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing. Thank you! I don't understand it fully yet... will look at it tomorrow. |
|
Very well spotted! The issue was that when BS accepts a step, it overwrites the initial y array by swapping a pointer, rather than copying all the individual values (because it's faster). And yes, to the other issue regarding the time during collisions! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Hanno, this one was quite tricky but think I figured it out!
Some issues with the scope of nbody_ode. After a merge (and seemingly only after a merge), only the local variable nbody_ode is updated, not the global r->odes[0]. To be honest I don't entirely understand why your code didn't work, everything looked fine to me - but I reassign y within the loop now and it seems to work.
Unrelated bug, but realized over the course of debugging that it's important to still update the actual r->t variable during the bs step. collision_resolve checks the last time of collision against the current simulation time, so this fails if the collision happens during the first call of bs_step.