Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRS Condition #763

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Conversation

tigerchenlu98
Copy link
Contributor

Apologies, I was too hasty with the previous merge... git hackery turned out to be troublesome so I thought a new PR was best. Everything looks good here.

@hannorein hannorein merged commit 100848a into hannorein:newTRACE4_FULL Mar 29, 2024
4 of 33 checks passed
@hannorein
Copy link
Owner

hannorein commented Mar 29, 2024

Thanks for the cleanup. I merged it and also:

  • removed the debug function
  • fixed the structure in the python wrapper now that there is one additional parameter
  • renamed peri_default to peri_pham to be more descriptive

@hannorein
Copy link
Owner

The unit tests still need some work to pass..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants