Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reduction count to 4K #130

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Conversation

hirotnk
Copy link
Collaborator

@hirotnk hirotnk commented Mar 7, 2020

No description provided.

@kvakvs
Copy link
Collaborator

kvakvs commented Mar 7, 2020

Please keep both old and new value and at least major version when it was changed. Old value still is "valuable" 😀

@hirotnk
Copy link
Collaborator Author

hirotnk commented Mar 7, 2020

@kvakvs Thank you for the review, how about introducing some format that can be used in everywhere in the document for similar situations? For example, Erlang doc has info for APIs since when it was introduced or modified like OTP R13B04.
Also, I wish we could introduce some variables to be referenced from multiple places in the document so that we don't have to modify multiple times.

@happi
Copy link
Owner

happi commented Mar 7, 2020

Yes, let us continue the versioning question in your previous issue #77 and just add a note here.

Thanks for the contribution.

@hirotnk
Copy link
Collaborator Author

hirotnk commented Mar 8, 2020

@happi @kvakvs Added link to the source and note. On my local, it looks like:
Screen Shot 2020-03-07 at 20 02 04
and
Screen Shot 2020-03-07 at 20 02 50

@hirotnk
Copy link
Collaborator Author

hirotnk commented Mar 8, 2020

I also tried differently:
Screen Shot 2020-03-07 at 20 59 41
and
Screen Shot 2020-03-07 at 20 59 53

Please let me know which is better, or if there is any suggestion. I'll make a change accordingly.

@happi
Copy link
Owner

happi commented Mar 8, 2020

I like the one with the “version info” title.

@hirotnk
Copy link
Collaborator Author

hirotnk commented Mar 8, 2020

@happi Updated.

@happi happi merged commit 0243123 into happi:master Mar 8, 2020
@happi
Copy link
Owner

happi commented Mar 8, 2020

Thanks.

Remind me to do a new release soon. I should take the time and do some other fixes also.

@hirotnk
Copy link
Collaborator Author

hirotnk commented Mar 8, 2020

Great, thank you too!

andreabenini added a commit to andreabenini/theBeamBook that referenced this pull request Mar 18, 2020
Update reduction count to 4K (happi#130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants