Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUG/MINOR: quic: fix CONNECTION_CLOSE_APP encoding
CONNECTION_CLOSE_APP encoding is broken, which prevents the sending of every packet with such a frame. This bug was always present in quic haproxy. However, it was slightly dissimulated by the previous code which always initialized all frame members to zero, which was sufficient to ensure CONNECTION_CLOSE_APP encoding was ok. The below patch changes this behavior by removing this costly initialization step. 4cf784f MINOR: quic: Avoid zeroing frame structures Now, frames members must always be initialized individually given the type of frame to used. However, for CONNECTION_CLOSE_APP this was not done as qc_cc_build_frm() accessed the wrong union member refering to a CONNECTION_CLOSE instead. This bug was detected when trying to generate a HTTP/3 error. The CONNECTION_CLOSE_APP frame encoding failed due to a non-initialized <reason_phrase_len> which was too big. This was reported by the following trace : "frame building error : qc@0x5555561b86c0 idle_timer_task@0x5555561e5050 flags=0x86038058 CONNECTION_CLOSE_APP" This must be backported up to 2.6. This is necessary even if above commit is not as previous code is also buggy, albeit with a different behavior.
- Loading branch information