fix(stats): use unicode explicit icon #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the NEGATIVE SQUARED LATIN CAPITAL LETTER E unicode character for the explicit icon ("🅴"), instead of just a plaintext character ("E") styled by the
main-tag-containerclass.The goal is to fix an issue where the explicit icon is just an empty box, depending on the theme and the background color that the
main-tag-containerclass has. For instance, using the Sleek theme, the explicit icon is just a solid white box:Switching to the unicode character, removing the
main-tag-containerclass, and setting thecolorto thespice-textCSS variable seems to produce much more consistent results across various themes. It has the added advantage of being closer in appearance to the actual Spotify explicit icon. For instance, using the same theme: