Finish syncing to 4.2.1 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows mix-and-matching per-syllable and other lookups. In fact, removes the clear-syllables call completely. harfbuzz/harfbuzz@044d7a06d
Test for the fix in 7bdc20e for the regression from 43be5ba. harfbuzz/harfbuzz@383c11d75
|
There was a typo at 767ff47 which was what stopped the tests from working earlier. So I git amended the fix onto that commit |
|
Oh cool! Thanks for doing this, I'll close my old PR then, not sure when I will have time to work on it again anyway... I used this Google Sheet document to keep track of it, and I basically copy the relevant commits into a Markdown converter. |
|
Thanks! Much appreciated! Don't worry, the changelog table isn't mandatory 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big thank you to @LaurenzV for starting this round of backporting!
This continues the effort started at #100
(Idk how to make or copy the fancy table you used so pretend it is here...)