Separate arcMap generation from writing to file #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be backwards-compatible so no dependent projects would break due to this. |
harishd10
requested changes
May 21, 2022
| std::vector<int64_t> nodeids; | ||
| std::vector<scalar_t> nodefns; | ||
| std::vector<char> nodeTypes; | ||
| std::vector<int64_t> arcs; | ||
|
|
||
| arcMap.resize(nv, -1); | ||
|
|
||
| uint32_t arcNo = 0; | ||
| for (int64_t i = 0; i < nv; i++) { |
There was a problem hiding this comment.
Why is there a nested loop here?
| @@ -145,6 +145,7 @@ ContourTree::computeArcMap() { | |||
|
|
|||
| return {arcNo, nodeids, nodefns, nodeTypes, arcs}; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Was this added because of the additional loop? Based in this, the return statement is anyway inside the second loop. Was the first loop a copy paste error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I separated the generation of the arcMap from writing it to file since writing to file might not be needed. One could instead directly work with the arcMap.