Refactor test_capture_job.py #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
kilbergr and
bensteinberg
and removed request for
a team and
kilbergr
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3415 +/- ##
===========================================
+ Coverage 68.62% 68.89% +0.26%
===========================================
Files 53 53
Lines 7236 7297 +61
===========================================
+ Hits 4966 5027 +61
Misses 2270 2270
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ENG-415.
This PR refactors test_capture_job.py:
a) to use pytest fixtures powered by factory boy instead of our json fixtures
b) to use standard pytest syntax instead of the older unittest-style syntax
This was easy, because I basically already went through this exercise in harvard-lil/perma-capture@b2fe7ad and related commits, when building the prototype capture service.
I hope to be able to reuse a lot of that work (as intended), as this refactoring project proceeds!
Reviewing
The unified diff is very hard to read, but I think if you click through the individual commits, you'll be able to easily see at a glance that the tests haven't been changed.