Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential form ID discrepancy between search form text input and button #3664

Conversation

cmsetzer
Copy link
Contributor

In #3659 we modified the search_form.html template so the search text input can point to an arbitrary form. (This is useful on the paid registrar approval page, because there are two forms that submit data using different methods.)

I missed one detail: if an arbitrary form_id is supplied, the search submission button needs to point to it as well. Otherwise, hitting Enter within the text input and clicking the submit button may produce unexpectedly different results.

@cmsetzer cmsetzer marked this pull request as ready for review November 22, 2024 18:51
@cmsetzer cmsetzer requested a review from a team as a code owner November 22, 2024 18:51
@cmsetzer cmsetzer requested review from bensteinberg and removed request for a team November 22, 2024 18:51
@cmsetzer cmsetzer merged commit fa61418 into harvard-lil:develop Nov 22, 2024
2 checks passed
@cmsetzer cmsetzer deleted the fix-paid-registrar-approval-search-form-submit-button branch November 22, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants