chore: bump kube-vip to v0.8.7 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Chart version: 0.6.4 - App version: v0.8.7 Signed-off-by: Zespre Chang <[email protected]>
bk201
approved these changes
Dec 19, 2024
|
@starbops Could you please also help: thanks. |
|
@w13915984028 my suggestion is to re-open #279 and merge it first then we can merge this one. |
Signed-off-by: Zespre Chang <[email protected]> Co-authored-by: Anton Donskoy <[email protected]> Co-authored-by: Jian Wang <[email protected]>
|
I've added the patch for the kube-vip switch. After this PR is merged, I'll close #279, #305, and #306. Thank you. cc @w13915984028 @adonskoy |
FrankYang0529
approved these changes
Dec 20, 2024
1 task
starbops
added a commit
to starbops/harvester-charts
that referenced
this pull request
Dec 20, 2024
* chore: bump kube-vip to v0.8.7 - Chart version: 0.6.4 - App version: v0.8.7 Signed-off-by: Zespre Chang <[email protected]> * fix(harvester-cloud-provider): allow to disable kube-vip Signed-off-by: Zespre Chang <[email protected]> Co-authored-by: Anton Donskoy <[email protected]> Co-authored-by: Jian Wang <[email protected]> --------- Signed-off-by: Zespre Chang <[email protected]> Co-authored-by: Anton Donskoy <[email protected]> Co-authored-by: Jian Wang <[email protected]>
FrankYang0529
pushed a commit
that referenced
this pull request
Dec 24, 2024
* chore: bump kube-vip to v0.8.7 (#316) * chore: bump kube-vip to v0.8.7 - Chart version: 0.6.4 - App version: v0.8.7 Signed-off-by: Zespre Chang <[email protected]> * fix(harvester-cloud-provider): allow to disable kube-vip Signed-off-by: Zespre Chang <[email protected]> Co-authored-by: Anton Donskoy <[email protected]> Co-authored-by: Jian Wang <[email protected]> --------- Signed-off-by: Zespre Chang <[email protected]> Co-authored-by: Anton Donskoy <[email protected]> Co-authored-by: Jian Wang <[email protected]> * chore: bump cloud-provider to 0.2.7 - chart version: 0.2.7 - app version: v0.2.4 Signed-off-by: Zespre Chang <[email protected]> --------- Signed-off-by: Zespre Chang <[email protected]> Co-authored-by: Anton Donskoy <[email protected]> Co-authored-by: Jian Wang <[email protected]>
1 task
brandond
reviewed
Jan 9, 2025
Comment on lines
-68
to
-70
| {{- define "system_default_registry" -}} | ||
| {{- if .Values.global.cattle.systemDefaultRegistry -}} | ||
| {{- printf "%s/" .Values.global.cattle.systemDefaultRegistry -}} |
There was a problem hiding this comment.
This has broken support for system default registry, and will need to be fixed before this update can go into Rancher or RKE2.
There was a problem hiding this comment.
Thanks @brandond.
We are working on #322 for this issue.
cc @FrankYang0529, @bk201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping harvester-cloud-provider's dependency - kube-vip:
Related issue: harvester/harvester#6904