feat: add CSI controller affinity/anti-affinity rules #325
Conversation
|
Hi @ihcsim, |
This ensures the replicas are scheduled to run on distinct control plane nodes on the guest cluster. These rules are the same as those of the cloud provider. Signed-off-by: Ivan Sim <[email protected]>
ihcsim
force-pushed
the
csi-driver-affinity
branch
from
54f0c5c to
a6d457e
Compare
|
@Vicente-Cheng Rebased completed - thanks. |
|
iirc if the template changes in the release branch, we need to bump the chart version. @Vicente-Cheng can you confirm? |
Ah... yeah, nice catch! |
Signed-off-by: Ivan Sim <[email protected]>
|
@bk201 @Vicente-Cheng Version updated in cbb57d9. Let me know if this looks right. I am going by how it was done in #315. Thanks. |
|
|
||
| # This is the version number of the application being deployed. This version number should be | ||
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| appVersion: "v0.2.2" | ||
| appVersion: "v0.2.3" |
There was a problem hiding this comment.
The appVersion is associated with the Harvester CSI image version.
As you saw here (https://github.com/harvester/harvester-csi-driver/releases), the latest image version is v0.2.2.
We could skip updating the appVersion at this moment.
Just updating the Chart version from 0.1.22 -> 0.1.23 is enough.
| @@ -7,7 +7,7 @@ image: | |||
| csiDriver: | |||
| repository: rancher/harvester-csi-driver | |||
| # Overrides the image tag whose default is the chart appVersion. | |||
| tag: "v0.2.2" | |||
| tag: "v0.2.3" | |||
There was a problem hiding this comment.
ditto, we did not need to update tag
Signed-off-by: Ivan Sim <[email protected]>
This PR cherry-picked #323 from the
masterbranch.Relevant issue: harvester/harvester#7189
Note #326 needs to be merged for CI to pass.