Skip to content

Commit

Permalink
Merge pull request #1210 from harvester/mergify/bp/release-harvester-…
Browse files Browse the repository at this point in the history
…v1.4/pr-1209

feat: Change LH V2 enablement from Preview to Experimental (backport #1209)
  • Loading branch information
torchiaf authored Oct 22, 2024
2 parents 4ad9d4a + 43796d9 commit d67f12e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions pkg/harvester/components/SettingList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ export default {
<span v-if="setting.customized" class="modified">
Modified
</span>
<span v-if="setting.technicalPreview" v-clean-tooltip="t('advancedSettings.technicalPreview')" class="technical-preview">
Technical Preview
<span v-if="setting.experimental" v-clean-tooltip="t('advancedSettings.experimental')" class="experimental">
Experimental
</span>
</h1>
<h2 v-clean-html="t(setting.description, {}, true)">
Expand Down Expand Up @@ -216,9 +216,9 @@ export default {
font-size: 12px;
}
.technical-preview {
.experimental {
margin-left: 10px;
border: 1px solid var(--warning);
border: 1px solid var(--error);
border-radius: 5px;
padding: 2px 10px;
font-size: 12px;
Expand Down
2 changes: 1 addition & 1 deletion pkg/harvester/config/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const HCI_ALLOWED_SETTINGS = {
kind: 'json', from: 'import', canReset: true
},
[HCI_SETTING.KUBECONFIG_DEFAULT_TOKEN_TTL_MINUTES]: {},
[HCI_SETTING.LONGHORN_V2_DATA_ENGINE_ENABLED]: { kind: 'boolean', technicalPreview: true },
[HCI_SETTING.LONGHORN_V2_DATA_ENGINE_ENABLED]: { kind: 'boolean', experimental: true },
[HCI_SETTING.ADDITIONAL_GUEST_MEMORY_OVERHEAD_RATIO]: { kind: 'string', from: 'import' },
};

Expand Down
2 changes: 1 addition & 1 deletion pkg/harvester/l10n/en-us.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1488,7 +1488,7 @@ harvester:
placeholder: 'topology.kubernetes.io/zone'

advancedSettings:
technicalPreview: 'Technical Previews allow users to test and evaluate early-access functionality prior to official supported releases'
experimental: 'Experimental features allow users to test and evaluate early-access functionality prior to official supported releases'
descriptions:
'harv-vlan': Default Network Interface name of the VLAN network.
'harv-backup-target': Custom backup target to store virtual machine backups.
Expand Down

0 comments on commit d67f12e

Please sign in to comment.