Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: disable master branch build #1250

Merged
merged 1 commit into from
Jan 7, 2025
Merged

ci: disable master branch build #1250

merged 1 commit into from
Jan 7, 2025

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Dec 30, 2024

Summary

ci: disable master branch build

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#7089

@a110605 a110605 self-assigned this Dec 30, 2024
@a110605 a110605 mentioned this pull request Dec 30, 2024
Merged
2 tasks
bk201
bk201 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, in general we don't commit comment out codes. But it's OK if this provide more context.

torchiaf
torchiaf approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Reminder: we can merge this only after the new release workflow is up & running in Harvester UI Extension repo.

@a110605 a110605 merged commit d527e97 into harvester:master Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf torchiaf approved these changes

@bk201 bk201 bk201 approved these changes

@houhoucoop houhoucoop Awaiting requested review from houhoucoop

Assignees

@a110605 a110605

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a110605 @bk201 @torchiaf