Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port AppModal component to harvester source code (backport #1249) #1252

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 2, 2025

Summary

Previous PR port AppModal component from Rancher/shell to harvester shell. But the appModal was introduced after Rancher 2.9+ which causes it doesn't exist on Rancher 2.8.

This PR port AppModal component to harvester source code.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#7147

Screenshot/Video

1. Import harvester into Rancher 2.8 or 2.9
2. Pull this PR locally and run `yarn build-pkg harvester && yarn serve-pkgs`
3. Change 
   - ui-plugin-index setting to http://127.0.0.1:4500/harvester-1.4.0/harvester-1.4.0.umd.min.js
   - ui-source to external
4. Refresh

Test on Rancher 2.9

2.9.2.mov

Test on Rancher 2.8

2.8.5.mov

This is an automatic backport of pull request #1249 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <[email protected]>
(cherry picked from commit 9994e47)
@mergify mergify bot added the Backport to v1.4 Backport PR target v1.4 label Jan 2, 2025
@mergify mergify bot assigned a110605 Jan 2, 2025
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 requested a review from houhoucoop January 2, 2025 02:58
@bk201 bk201 merged commit 4498399 into release-harvester-v1.4 Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants